Skip to content

gpui_linux: Clear X11 urgency hint on focus - #62550

Open
melocene wants to merge 1 commit into
zed-industries:mainfrom
melocene:fix_x11_notifications
Open

gpui_linux: Clear X11 urgency hint on focus#62550
melocene wants to merge 1 commit into
zed-industries:mainfrom
melocene:fix_x11_notifications

Conversation

@melocene

@melocene melocene commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Objective

Fixes #61679

Solution

Clear the X11 WM_HINTS urgency flag when a window receives focus, while preserving the other window manager hints.

Testing

  • Did you test these changes? If so, how?

    • cargo check -p gpui_linux
    • cargo test -p gpui_linux --lib
    • Manual Xfce verification was not completed as the dev version would not properly authenticate me with GitHub Copilot, though it did show as signed in.

Reviewers can reproduce #61679 on XFCE using xprop WM_HINTS to confirm that the urgency hint is cleared after focusing Zed.

  • Are there any parts that need more testing?

Shouldn't be as this is just another method in a similar style as the existing.

  • How can other people (reviewers) test your changes? Is there anything specific they need to know?

Compile and run Zed on a system running XFCE4.

  • If relevant, what platforms did you test these changes on, and are there any important ones you can't test?

Arch Linux with XFCE 4.20

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • [] The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed Zed continuing to demand attention after regaining focus on X11.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Aug 12, 2026
@melocene melocene changed the title Clear X11 urgency hints on focus gpui_linux: Clear X11 urgency hint on focus Aug 12, 2026
@dinocosta dinocosta added platform:linux/x11 happens only on Linux X11 area:gpui GPUI rendering framework support labels Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:gpui GPUI rendering framework support cla-signed The user has signed the Contributor License Agreement platform:linux/x11 happens only on Linux X11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor doesn't handle urgent hint window signal correctly in Xfce

2 participants